Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Replayer API and rr_id #394

Merged
merged 9 commits into from
Aug 15, 2023
Merged

feature: Replayer API and rr_id #394

merged 9 commits into from
Aug 15, 2023

Conversation

rustatian
Copy link
Collaborator

@rustatian rustatian commented Jul 31, 2023

Reason for This PR

closes: roadrunner-server/roadrunner#1640

Description of Changes

  • Add support for the ReplayAPI (according to the specs in the ticket).
  • Move all proto to the roadrunner-server/api.
  • rr_id per workflow run.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jul 31, 2023
@rustatian rustatian requested a review from wolfy-j July 31, 2023 15:24
@rustatian rustatian self-assigned this Jul 31, 2023
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian changed the title feature: Replayer API and Update workflow handler feature: Replayer API and rr_id Aug 15, 2023
@rustatian rustatian marked this pull request as ready for review August 15, 2023 13:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #394 (b906789) into master (f6c5224) will increase coverage by 0.33%.
The diff coverage is 16.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   22.34%   22.67%   +0.33%     
==========================================
  Files           4        4              
  Lines         273      269       -4     
==========================================
  Hits           61       61              
+ Misses        210      206       -4     
  Partials        2        2              
Files Changed Coverage Δ
internal/protocol.go 0.00% <ø> (ø)
queue/queue.go 86.84% <16.66%> (+8.27%) ⬆️

@rustatian rustatian merged commit 3517136 into master Aug 15, 2023
5 of 6 checks passed
@rustatian rustatian deleted the feature/replayer-api branch August 15, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Temporal Replay API
3 participants