Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request trigger for closed trigger type #6

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

XaF
Copy link
Contributor

@XaF XaF commented Feb 9, 2024

What was changed

Add pull_request / closed trigger.

Why?

For some reason, it does not seem to trigger for pull_request_target right now; it might be related to merge queues only (since it seems to have closed others properly when merge queues are not involved), but it leaves exceptions requests pull requests open instead of tagging them properly and closing them.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

For some reason, it does not seem to trigger for `pull_request_target` right now; it might be related to merge queues only (since it seems to have closed others properly when merge queues are not involved), but it leaves exceptions requests pull requests open instead of tagging them properly and closing them.
@XaF XaF requested a review from jackdawm February 9, 2024 22:30
@XaF XaF requested a review from a team as a code owner February 9, 2024 22:30
@XaF XaF merged commit b6d6e78 into main Feb 20, 2024
5 checks passed
@XaF XaF deleted the xaf/duplicate_closed_trigger_for_pull_request branch February 20, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants