fix: Populate SQL_CONNECT_ATTRIBUTES in admintools and schema job #567
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
When
server.persistence.config.*.sql.connectAttributes
is set, also populate theSQL_CONNECT_ATTRIBUTES
env var in thetemporal-schema
job. According to https://github.com/temporalio/temporal/blob/main/tools/sql/handler.go#L157, theSQL_CONNECT_ATTRIBUTE
env var must be in this format:key1=value1&key2=value
.Why?
If users want to use a different schema than
public
, they need to set theconnectAttribute
value to something likesearch_path: temporal
. With this PR, thetemporal-schema
job will know about it and create tables in the right schema.Checklist
Closes [Feature Request] Ability to specify SQL_CONNECT_ATTRIBUTES for temporal-schema job #561
How was this tested:
helm lint charts/temporal
connectAttributes
to charts/temporal/values/values.postgresql.yaml:helm template my-release charts/temporal -f charts/temporal/values/values.postgresql.yaml
SQL_CONNECT_ATTRIBUTES
env var:main
and against my branch, checking the resulting yamls are the same.