Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerSecurityContexts to all initContainers #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hikhvar
Copy link

@hikhvar hikhvar commented Sep 24, 2024

What was changed

Added containerSecurityContexts to all initContainers in server-job.

Why?

Our internal platform enforces strict security contexts. Without this patch, we are unable to run the jobs.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@hikhvar hikhvar requested a review from a team as a code owner September 24, 2024 19:03
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@robholland robholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tweak.

@@ -53,6 +65,10 @@ spec:
volumeMounts:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with $.Values.schema.containerSecurityContext }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the indent a step as per the block above.

@robholland robholland added the needs revision Team has requested some changes label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs revision Team has requested some changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants