Fix schema job cleanup by adding optional hook annotation #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds optional chart hook annotations to schema job. This
pre-installhook will make sure the job gets run before any other deployment, and will automatically cleans up the job after it's finished with ahook-delete-policy.Why?
If the schema job is not garbage collected helm upgrades are not possible.
Also if the job doesn't get run first, other deployments can fail (at least initially) until the job is finished.
Checklist
Closes [Bug]
helm upgradedoes not work ifschema.enabledis true #554How was this tested:
Run helm install, check the job runs first before any other deployment, and check the job gets deleted after completion.
Any docs updates needed?
I don't think there is any doc for this.