Remove prometheus dependency #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robholland
approved these changes
Oct 3, 2024
BrianKopp
force-pushed
the
remove-prometheus-dep-2
branch
from
963a503
to
ae7d49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Breaking changes:
prometheus.enabled.prometheus.io/*) are no longer created by default on servicesWhy?
Monitoring layer should not be prescribed by the application layer.
Checklist
Closes [Feature Request] Remove Prometheus dependency #527
How was this tested:
[x] - compared helm template results
[ ] - temporal installed successfully without prometheus
[ ] - temporal ServiceMonitor successfully picked up by prometheus operator
Any docs updates needed?
README was updated