Remove grafana dependency #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robholland
approved these changes
Jul 8, 2024
BrianKopp
force-pushed
the
remove-grafana-dependency
branch
from
9bc61ed
to
006c30d
Compare
BrianKopp
force-pushed
the
remove-grafana-dependency
branch
from
006c30d
to
3ce77d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed Grafana dependency and related config.
Why?
Configuration & installation of monitoring tools is a cluster-level consideration, and shouldn't be specified in an application such as this.
Checklist
Closes [Feature Request] Remove dependency on Grafana #518
How was this tested:
Diff between
helm templatemain and this branch has no differences.Note - if running
helmfrom the directory or source, and if you don't runhelm dependencies update, then helm will want to install grafana since it's enabled by default.README is updated.
This will be a breaking change for folks who have grafana enabled, since it will delete their temporal-installed-grafana.