Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update obsolete transaction isolation level attribute for aurora… #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Julien4218
Copy link

…/mysql

What was changed

The tx_transaction is no longer available with the most recent aurora/mysql version.
That attribute is now replaced with transaction_isolation.
AWS documentation for reference https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Reference.ParameterGroups.html
I've tested this change on the most recent aurora/mysql version 8.0.mysql_aurora.3.06.0

Why?

Without this change the temporal servers won't start. Here is the error message from one of the pod crashing:

Error 1193: Unknown system variable 'tx_isolation'

Checklist

  1. Closes

  2. How was this tested:

On latest Aurora/MySQL version version 8.0.mysql_aurora.3.06.0 with temporal version 1.30.0

  1. Any docs updates needed?

@Julien4218 Julien4218 requested review from a team as code owners May 3, 2024 02:13
@CLAassistant
Copy link

CLAassistant commented May 3, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@robholland
Copy link
Contributor

Please sign the CLA.

@robholland robholland added the needs revision Team has requested some changes label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs revision Team has requested some changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants