Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being able to disable prom annotations #399

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Being able to disable prom annotations #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a449a
fix: being able to disable prom annotations at the service level
SmaineTF1 Jul 3, 2023
ce624a0
fix: default prometheus annotations should be set to false at the ser…
SmaineTF1 Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion templates/server-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,12 @@ metadata:
app.kubernetes.io/component: {{ $service }}
app.kubernetes.io/part-of: {{ $.Chart.Name }}
app.kubernetes.io/headless: 'true'
{{- if $serviceValues.metrics.annotations.enabled }}
prometheus.io/job: {{ $.Chart.Name }}-{{ $service }}
prometheus.io/scrape: 'true'
prometheus.io/scheme: http
prometheus.io/port: "9090"
prometheus.io/port: '9090'
{{- end }}

annotations:
# Use this annotation in addition to the actual field below because the
Expand Down
6 changes: 3 additions & 3 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ server:
port: 7233
metrics:
annotations:
enabled: true
enabled: false
serviceMonitor: {}
# enabled: false
prometheus: {}
Expand All @@ -193,7 +193,7 @@ server:
port: 7234
metrics:
annotations:
enabled: true
enabled: false
serviceMonitor: {}
# enabled: false
prometheus: {}
Expand Down Expand Up @@ -237,7 +237,7 @@ server:
port: 7239
metrics:
annotations:
enabled: true
enabled: false
serviceMonitor: {}
# enabled: false
prometheus: {}
Expand Down