Being able to set environment variables using 'envFrom' #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
underrun
approved these changes
Jun 30, 2023
XaF
reviewed
Jun 30, 2023
XaF
approved these changes
Jul 5, 2023
|
What about this PR? Do you need anything else? |
|
+1 to that. |
|
@sgrzemski sorry, I'm confused but what should I do for that check? This is not obvious to me :/ |
|
@SmaineTF1 : |
|
Should I do something anyway @sgrzemski please? |
robholland
requested changes
Jun 8, 2024
| @@ -84,6 +84,8 @@ server: | |||
| additionalVolumes: [] | |||
| additionalVolumeMounts: [] | |||
| additionalEnv: [] | |||
| additionalEnvCM: [] | |||
There was a problem hiding this comment.
Please use additionalEnvConfigMap rather than using a contraction.
robholland
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add the ability to define environment variables that come from configmaps or secrets
Why?
Make use of envFrom is pretty handy when, for instance you have all the environment variables defined in Secrets or Configmaps.
That way we only need to have this bit of code if we have all the config env vars in a secret