Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove Prometheus dependency #527

Open
BrianKopp opened this issue Jul 5, 2024 · 0 comments · Fixed by #534
Open

[Feature Request] Remove Prometheus dependency #527

BrianKopp opened this issue Jul 5, 2024 · 0 comments · Fixed by #534
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@BrianKopp
Copy link

BrianKopp commented Jul 5, 2024

Is your feature request related to a problem? Please describe.

Monitoring tools shouldn't be specified by this application.

Describe the solution you'd like

Remove dependencies on monitoring tools.

Additional context

We'll want to remove the dependency on the prometheus helm chart, but still provide a reasonable way to enable prometheus metric scraping. This will be accomplished via the conditional ServiceMonitor.

The hard-coded labels that were in this chart beforehand (prometheus.io/*) aren't necessary if we are providing a ServiceMonitor as a standard way for discovering targets. They should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants