automatically pull latest version for build.gradle #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Oct 28, 2024
|
|
||
| dependencies { | ||
| implementation 'ch.qos.logback:logback-classic:1.2.9' | ||
| implementation 'com.google.guava:guava:31.0.1-jre' | ||
| implementation 'com.google.code.gson:gson:2.8.9' | ||
| implementation 'com.jayway.jsonpath:json-path:2.6.0' | ||
| implementation 'info.picocli:picocli:4.6.2' | ||
| implementation 'io.temporal:temporal-sdk:1.26.1' | ||
| implementation "io.temporal:temporal-sdk:${latestSdkVersion}" |
There was a problem hiding this comment.
I wonder if this is something that needs to be done at runtime of features instead of inside the build.gradle. IIUC every SDK language in features has a fixed default that can be overridden at runtime? Why override in this gradle instead of via CLI args of the features CLI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Auto pull the latest release from
sdk-javaWhy?
This should now match the version that CI pulls from changes made in #530
Checklist
Pulls the correct version locally