Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sdk-go to 1.32.0 #449

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Upgrade sdk-go to 1.32.0 #449

merged 2 commits into from
Apr 11, 2024

Conversation

ShahabT
Copy link
Contributor

@ShahabT ShahabT commented Apr 10, 2024

What was changed

Upgrade sdk-go to 1.32.0 and renamed usages of UseCompatibleVersion to make it compilable.

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

cretz
cretz reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also have to update .github/workflows/ci.yaml to reference this new version

@ShahabT
Copy link
Contributor Author

ShahabT commented Apr 10, 2024

@cretz good to know. I'm waiting for sdk-go release to be published before I upgrade it here, will upgrade it in the ci.yml file too.

@ShahabT ShahabT merged commit 944162e into main Apr 11, 2024
18 checks passed
@ShahabT ShahabT deleted the shahab/upgrade-sdk-go branch April 11, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz left review comments

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShahabT @cretz @Quinn-With-Two-Ns