Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around java sdk issue 1973 #413

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Work around java sdk issue 1973 #413

merged 2 commits into from
Jan 19, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Currently the Java SDK is incorrectly wrapping the UpdateWorkflowExecption in a ExecutionException on a sync update call if the SDK falls back to polling the update.

work around this issue temporalio/sdk-java#1973

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review January 19, 2024 19:20
dandavison
dandavison approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 0dfcb1a into temporalio:main Jan 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @dandavison