Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set deadline on timeout_due_to_no_active_workers/feature.ts and upgrade to TS SDK 1.9.0 #401

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Set deadline on timeout_due_to_no_active_workers/feature.ts and upgrade to TS SDK 1.9.0 #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23cab9d
Set deadline on timeout_due_to_no_active_workers/feature.ts
bergundy Jan 12, 2024
8f9551f
Upgrade to TS SDK 1.9.0 and install SDK specific packages
bergundy Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
feature-tests-ts:
uses: ./.github/workflows/typescript.yaml
with:
version: 1.5.2
version: 1.9.0
version-is-repo-ref: false
features-repo-ref: ${{ github.head_ref }}
features-repo-path: ${{ github.event.pull_request.head.repo.full_name }}
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
with:
do-push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
go-repo-ref: '77626eee301574bc4cfd756dbf0641c61e9e6907'
ts-ver: 'v1.5.2'
ts-ver: 'v1.9.0'
java-ver: 'v1.22.0'
py-ver: 'v1.4.0'
cs-ver: 'v0.1.0-beta2'
2 changes: 1 addition & 1 deletion features/query/timeout_due_to_no_active_workers/feature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const feature = new Feature({
await runner.workerRunPromise;
// Make a query, it will time out
try {
await wfHandle.query(query);
await runner.client.withDeadline(new Date(Date.now() + 1000), () => wfHandle.query(query));
} catch (e) {
assert.ok(e instanceof ServiceError);
const reAnyd = e as any;
Expand Down
Loading
Loading