Don't use class attributes for mutable workflow state (#509)

temporalio · Jul 10, 2024 · 71fcce8 · 71fcce8
1 parent 6d0cc91
commit 71fcce8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/features/update/basic/feature.py b/features/update/basic/feature.py
@@ -9,7 +9,8 @@
 
 @workflow.defn
 class Workflow:
-    am_done = False
+    def __init__(self) -> None:
+        self.am_done = False
 
     @workflow.run
     async def run(self) -> str:

diff --git a/features/update/self/feature.py b/features/update/self/feature.py
@@ -9,7 +9,8 @@
 
 @workflow.defn
 class Workflow:
-    am_done = False
+    def __init__(self) -> None:
+        self.am_done = False
 
     @workflow.run
     async def run(self) -> str:

diff --git a/features/update/task_failure/feature.py b/features/update/task_failure/feature.py
@@ -12,7 +12,8 @@
 
 @workflow.defn
 class Workflow:
-    am_done = False
+    def __init__(self) -> None:
+        self.am_done = False
 
     @workflow.run
     async def run(self) -> str:

diff --git a/features/update/validation_replay/feature.py b/features/update/validation_replay/feature.py
@@ -13,7 +13,8 @@
 
 @workflow.defn
 class Workflow:
-    am_done = False
+    def __init__(self) -> None:
+        self.am_done = False
 
     @workflow.run
     async def run(self) -> str: