Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sgryphon
Copy link
Contributor

@sgryphon sgryphon commented Jun 8, 2020

  • Add nuget link
  • Remove TOC

@sgryphon sgryphon requested a review from tonesandtones June 8, 2020 07:38
@tonesandtones
Copy link
Contributor

Why no coverage on PR to master? Is that what you can't get working?

@sgryphon
Copy link
Contributor Author

Why no coverage on PR to master? Is that what you can't get working?

I noticed this PR (which is just a Readme change) is still sitting here.

The issue is that the Pull Request build is triggered by my account, which doesn't have permission to do the code coverage, so it fails.

I changed the repository to have two action workflows:

  1. build-test-coverage.yml, which is the same as the original, and runs build, test, and the coverage report on local branches for master and feature/*

  2. change build-test.yml, which runs on pull-requests to master (possibly from a forked repo), and that only runs build and test.

The reason why coverage doesn't run on a PR initiated from a forked repo is that any external person could do that, so you want to be careful about the resources used by external people.


If you want to run coverage internally, then you can always pull my feature branch into the repo, and then build that. Or maybe we can set up a way to manually run the action (by an authorised person).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants