[TEST]: Improvement: Server42: Isl Rtt #5761
Conversation
| islUtils.waitForIslStatus([newIsl, newIsl.reversed], MOVED) | ||
| northbound.deleteLink(islUtils.toLinkParameters(newIsl)) | ||
| wait(WAIT_OFFSET) { assert !islUtils.getIslInfo(newIsl).isPresent() } | ||
| if(islUtils.getIslInfo(newIsl).isPresent()) { |
There was a problem hiding this comment.
In the majority of the tests we have restoring replug in the scope of the test and there is no need to execute the following calls if there is no such link (already recovered).
| @@ -151,6 +151,11 @@ isls: | |||
| dst_switch: ofsw8 | |||
| dst_port: 7 | |||
|
|
|||
| - src_switch: ofsw7 | |||
There was a problem hiding this comment.
Added this isl to be able to execute ISL RTT stats are not available for a moved link and available for a new link on virtual env (low priority )
| def checkpointTime = new Date().getTime() | ||
| wait(islSyncWaitSeconds + WAIT_OFFSET, 2) { | ||
| assert islStats.of(isl).get(ISL_RTT, SERVER_42).hasNonZeroValuesAfter(checkpointTime) | ||
| assert islStats.of(isl.reversed).get(ISL_RTT, SERVER_42).hasNonZeroValuesAfter(checkpointTime) |
There was a problem hiding this comment.
Replaced checkIslRttStats with direct stats check:
to clarify stats are available used wait(),
to clarify there is no stats used timedLoop().
| return changeIslRttSwitch(sw, islRttEnabled ? RttState.ENABLED.toString() : RttState.DISABLED.toString()) | ||
| } | ||
|
|
||
| def changeIslRttSwitch(Switch sw, String requiredState) { |
There was a problem hiding this comment.
Moved to switchHelper and replaced switchHelper.updateSwitchProperties with direct NB call to update props.
switchHelper.updateSwitchProperties includes default rules/meters verification (covered in DefaultRules: Able to delete/install the server42 ISL RTT turning rule on a switch)
| } | ||
|
|
||
| def changeIslRttToggle(boolean requiredState) { | ||
| def originalState = featureToggles.getFeatureToggles().server42IslRtt |
There was a problem hiding this comment.
replaced with
featureToggles.getFeatureToggles().server42IslRtt == requiredState ?: featureToggles.server42IslRtt(requiredState)
yuliiamir
added
area/testing
improvement
Ready to Merge
and removed
Ready to Merge
labels
yuliiamir
force-pushed
the
test/improvement-s42-isl
branch
from
335080b to
d477f31
Compare
No description provided.