Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Address Page Display and Contract Manager Optimization #869

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Conversation

pmjanus
Copy link
Contributor

@pmjanus pmjanus commented Nov 7, 2024

Fixes #829 #860

Description

  • Added blockie icons to address/contract/token pages for better visual identification
  • Replaced generic icons with blockie-icons for contracts and normal addresses
  • Retained token icons for ERC-20 tokens
  • Increased field width for function names to show complete names
  • Optimized contract manager by removing null address list cache
  • Improved performance by using cached contract metadata from indexer API queries
  • Eliminated redundant API calls to /v1/contract/{address}

Test scenarios

  1. Address Icons:

    • Verify blockie icon display at: /address/0x77F0Db20D64051D081170e95fC0d0F5aa40C249c
    • Check contract icon at: /address/0x3B7023f3C99EAe2FA0AaeB9490A78d5D98a24148
    • Confirm token icon at: /address/0xB4B01216a5Bc8F1C8A33CD990A1239030E60C905?tab=transactions
  2. Contract Manager:

    • Clear site data in Dev Tools (Applications Tab > Storage)
    • Navigate to address 0x0e79065B5F11b5BD1e62B935A600976ffF3754B9
    • Verify no additional calls to /v1/contract/{address}
    • Check Transactions Page for absence of redundant contract metadata queries

Checklist:

  • I have performed a self-review of my own code
  • I have commented code for complex icon generation logic
  • My changes generate no new warnings
  • I have tested for mobile functionality
  • Performance improvements have been verified
  • UI changes have been tested across different address types
  • Cache optimization has been thoroughly tested

Viterbo and others added 5 commits November 3, 2024 12:28
…sscontracttoken-pages

#829 | address page has blockie icon (based on address)
…the-address-page-still-makes-a-separate-query-to-get-possible-contract-metadata-for-each-address

#860 | Contract Manager improvement
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 3300def
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/672cce25f482240008db97ff
😎 Deploy Preview https://deploy-preview-869--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 3300def
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/672cce25bd31080008e47632
😎 Deploy Preview https://deploy-preview-869--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 3300def
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/672cce25a94beb0008a3c7ed
😎 Deploy Preview https://deploy-preview-869--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for teloscan ready!

Name Link
🔨 Latest commit 3300def
🔍 Latest deploy log https://app.netlify.com/sites/teloscan/deploys/672cce25b899050008cf367d
😎 Deploy Preview https://deploy-preview-869--teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus merged commit 374973b into master Nov 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add identicons to address/contract/token pages.
2 participants