-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#534 | Redesign - Block page #542
Conversation
✅ Deploy Preview for teloscan-redesign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… 534-block-route-redesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! I think a few changes are needed:
- i think the css class names in BlockPage.vue are off, instead of
p-block
i think they should bec-block
(sorry 😭) to match other components - there should be a singular and plural version for the text "X transactions in this block", like where there is 1 it should say "1 transaction in this block"
- can you make the info icons (for the tooltips) and the labels gray instead of black/white? i think especially in light mode they look a little intense
- instead of 2 separate cards for the parts of the page, i think they should be one card with an
<hr>
line separating them
- we need to decide how we want to have tabs appear with the redesign. this one is up for discussion because we have no designs for it. I personally think they should be styled to look more like other block explorers, like this but using our colors, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Viterbo please refactor BlockPage.vue to use setup
attribute (<script lang='ts' setup>
). See https://github.com/telosnetwork/teloscan/pull/540/files for refactor example and telos wallet for other component examples.
Fixes #534
Description
This PR implements the new design for the Block page, including two tabs that can be parametrized in the URL.
This PR also includes the Base redesign PR from @ezra-sg.
Test scenarios
Screenshots
|||
Checklist: