Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Indexer API #368

Closed
wants to merge 305 commits into from
Closed

Implement the Indexer API #368

wants to merge 305 commits into from

Conversation

tomtomcrypto
Copy link
Contributor

@tomtomcrypto tomtomcrypto commented Feb 23, 2023 •
edited
Loading

Fixes

Unblocks

Blocked by

  • Mainnet indexer
  • Testnet indexer

Description

Replaces RPC by the Indexer API
Adds holders, collections, nfts & allowance tab
Refactors Contract
Improve display on transaction page & table
....

Test scenarios

  • Website should work as it did before but a lot faster

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file
  • I have created a new issue with the required translations for the currently supported languages

@netlify
Copy link

netlify bot commented Feb 23, 2023 •
edited
Loading

✅ Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 91bea6c
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/65f85fc9b7d7c70008144f48
😎 Deploy Preview https://deploy-preview-368--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 23, 2023 •
edited
Loading

✅ Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 91bea6c
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/65f85fc9c96b250008ae63e4
😎 Deploy Preview https://deploy-preview-368--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomtomcrypto tomtomcrypto added the ✨ Enhancement Improvements on existing features label Feb 23, 2023
@tomtomcrypto tomtomcrypto self-assigned this Feb 23, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 23, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7b77b7
Status: ✅  Deploy successful!
Preview URL: https://5318a22d.teloscan.pages.dev
Branch Preview URL: https://indexer-api.teloscan.pages.dev

View logs

This was linked to issues Feb 26, 2023
Replace RPC with indexer API #367
Closed
Replace RPC by Indexer API for main transactions table #370
Closed
Replace RPC by Indexer API for transaction page internal transactions tab #374
Closed
Replace RPC by Indexer API for transaction page logs tab #372
Closed
Replace RPC by Indexer API for transaction page general tab #371
Closed
Replace RPC by Indexer API for account transfers pages #376
Closed
@tomtomcrypto tomtomcrypto linked an issue Mar 18, 2023 that may be closed by this pull request
Load NFT metadata URL by calling the contract using ethers as a fallback #384
Closed
@tomtomcrypto tomtomcrypto marked this pull request as ready for review March 18, 2023 18:04
@tomtomcrypto tomtomcrypto mentioned this pull request Mar 19, 2023
Open
ezra-sg
ezra-sg previously requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@ezra-sg ezra-sg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall amazing work, this is really clean. left a few comments and i think i may have found a bug too, details to follow

src/components/InternalTransactionTable.vue Outdated Show resolved Hide resolved
src/components/TokenList.vue Outdated Show resolved Hide resolved
src/components/Transaction/ERCTransferList.vue Outdated Show resolved Hide resolved
src/pages/AccountAddress.vue Outdated Show resolved Hide resolved
src/store/chain/actions.js Outdated Show resolved Hide resolved
src/store/transaction/index.js Outdated Show resolved Hide resolved
src/lib/contract/FragmentParser.js Outdated Show resolved Hide resolved
src/lib/contract/ContractManager.js Outdated Show resolved Hide resolved
src/components/InternalTransactionTable.vue Outdated Show resolved Hide resolved
src/lib/contract/ContractManager.js Outdated Show resolved Hide resolved
@ezra-sg

This comment was marked as resolved.

Sign in to view
@ezra-sg

This comment was marked as resolved.

Sign in to view
@ezra-sg

This comment was marked as resolved.

Sign in to view
@ezra-sg

This comment was marked as resolved.

Sign in to view
@ezra-sg

This comment was marked as resolved.

Sign in to view
@tomtomcrypto

This comment was marked as outdated.

Sign in to view
@tomtomcrypto
Copy link
Contributor Author

tomtomcrypto commented Mar 21, 2023 •
edited
Loading

Yeah so the problem here is that we do not have an API for testnet or stage yet so you shouldn't look at stage but the mainnet deploy or you'll have weird stuff as we use some mainnet services (API) & testnet ones (the rest).

https://deploy-preview-368--dev-mainnet-teloscan.netlify.app/

@tomtomcrypto

This comment was marked as outdated.

Sign in to view
@ezra-sg

This comment was marked as outdated.

Sign in to view
@ezra-sg

This comment was marked as outdated.

Sign in to view
@ezra-sg

This comment was marked as outdated.

Sign in to view
@ezra-sg

This comment was marked as outdated.

Sign in to view
@ezra-sg

This comment was marked as outdated.

Sign in to view
@ezra-sg

This comment was marked as outdated.

Sign in to view
@ezra-sg
Copy link
Contributor

ezra-sg commented Jan 30, 2024

i noticed while using this branch that there are some places where conditional logic is incorrect. i suggest adding this rule to eslintrc.js, 'no-mixed-operators': 'error', and running yarn lint, it will point out these issues. basically you just need to wrap some things in parentheses

ezra-sg
ezra-sg reviewed Feb 7, 2024
View reviewed changes
src/pages/AccountAddress.vue Outdated
<q-img
v-if="this.contract?.supportedInterfaces.includes('erc20')"
class="coin-icon"
:alt="this.contract.getName() + ' ERC20 token'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, it can cause problems if you use this keyword in templates. it should be like :alt="contract.getName() + ' ERC20 token'" as the this is automatically inferred. so that should be changed in this whole file's template, as well as in any other templates changed

@donnyquixotic
Copy link
Contributor

Any additional changes should be merged into #539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezra-sg ezra-sg ezra-sg left review comments

@donnyquixotic donnyquixotic donnyquixotic left review comments

Assignees

@tomtomcrypto tomtomcrypto

Labels
✨ Enhancement Improvements on existing features 🔧 Tech Debt Refactoring, library upgrades, documentation
Projects
None yet
Milestone
No milestone
6 participants
@tomtomcrypto @ezra-sg @donnyquixotic @Viterbo @poplexity @purveyorFF