Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The transaction tab on the address page still makes a separate query to get possible contract metadata for each address #860

Closed
Viterbo opened this issue Sep 22, 2024 · 0 comments
Closed

The transaction tab on the address page still makes a separate query to get possible contract metadata for each address #860

Viterbo opened this issue Sep 22, 2024 · 0 comments
Assignees
@Viterbo

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Sep 22, 2024 •
edited
Loading

Overview

Testing the performance of this PR on the branch #850 I notice that there are cases in which the transactions tab in the Address page is querying for every single unknown address throwing all the work of that PR throw the window.

Investigate why this is happening and fix it if possible.

Example case:
https://www.teloscan.io/address/0x0e79065B5F11b5BD1e62B935A600976ffF3754B9

Screencapture

image
@Viterbo Viterbo self-assigned this Sep 22, 2024
@Viterbo Viterbo mentioned this issue Nov 3, 2024
Merged
pmjanus added a commit that referenced this issue Nov 5, 2024
@pmjanus
Merge pull request #867 from telosnetwork/860-the-transaction-tab-on-…
3300def 
…the-address-page-still-makes-a-separate-query-to-get-possible-contract-metadata-for-each-address

#860 | Contract Manager improvement
@pmjanus pmjanus mentioned this issue Nov 7, 2024
Merged
7 tasks
@pmjanus pmjanus closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Viterbo @pmjanus