Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telos Cloud Login | simpler flow #757

Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jan 18, 2024

Fixes #753

Note: This PR is included in #759

Description

This PR implements an improved login experience for the Metakeep solution by skipping one step in the authentication flow. The previous prototype required two steps to access the Google Login Button. Now, it has been simplified to direct users straight to the Google Login Button. The main enhancements include:

  • Rendering the GoogleOneTap button on the first screen for a more efficient login process.
  • Ensuring that once logged in with Google, users are directed to the corresponding chain based on their selection.

Key changes:

  • Developed a new LoginButtons Component integrating the GoogleOneTap button and logic for handling the login flow for both EVM and Zero.
  • Replaced the existing EVMLoginButtons and ZeroLoginButtons components with the new LoginButtons component for a unified and streamlined interface.

Test Scenarios

  • Go to the updated login page.
  • Observe the GoogleOneTap button displayed on the first screen.
  • Select EVM or Zero
  • Log in using Google credentials.

Screenshots

Captura desde 2024-01-18 04-41-00

telos-wallet-login--better-flow.webm

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all English text in the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo self-assigned this Jan 18, 2024
@Viterbo Viterbo linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 45a6495
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/65a8d38ac54981000835b5e2
😎 Deploy Preview https://deploy-preview-757--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 45a6495
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65a8d38ac4e58f00081c7e60
😎 Deploy Preview https://deploy-preview-757--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo added the 🚫 Blocked Can't proceed with this issue or pull request label Jan 19, 2024
@Viterbo Viterbo changed the base branch from develop to 752-epic--telos-cloud-login January 19, 2024 21:10
@Viterbo Viterbo removed the 🚫 Blocked Can't proceed with this issue or pull request label Jan 24, 2024
@Viterbo Viterbo marked this pull request as ready for review January 24, 2024 14:32
@Viterbo Viterbo marked this pull request as draft January 29, 2024 15:42
@Viterbo Viterbo mentioned this pull request Feb 8, 2024
10 tasks
@Viterbo Viterbo marked this pull request as ready for review February 9, 2024 23:53
@Viterbo Viterbo merged commit c337d86 into 752-epic--telos-cloud-login Feb 9, 2024
9 checks passed
@Viterbo Viterbo mentioned this pull request Feb 12, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telos Cloud Login | Change the flow
1 participant