-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM and Zero login buttons looks the same #713
Conversation
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
// TODO: What should we do with this Authenticator? | ||
// new OreIdAuthenticator([chain], { | ||
// appId: process.env.OREID_APP_ID_NATIVE, | ||
// plugins: { popup: WebPopup() }, | ||
// }, | ||
// AuthProvider.Google), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do with this Authenticator?
It's the ORE-ID (old Cloud Wallet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove it
I close this PR because is included in #728 |
Fixes #712
Description
The Native section for login buttons was refactored so now both EVM and Native sections look the same
Login-Buttons.webm
Test scenarios
Checklist: