-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM Metakeep prototype #709
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viterbo
force-pushed
the
metakeep-auth
branch
from
December 6, 2023 16:32
2c92d29
to
665cd6f
Compare
Viterbo
force-pushed
the
metakeep-auth
branch
from
December 6, 2023 16:36
665cd6f
to
b7e9263
Compare
Viterbo
force-pushed
the
metakeep-auth
branch
from
December 18, 2023 13:07
0181b26
to
6f6d22d
Compare
I close this PR because it is updated here: #728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718
This PR includes the implementation of the potential replacement for Telos Cloud using MetaKeep as the main signing service.
EVM: A new EVMAuthenticator was created that fits perfectly into the class hierarchy we have for EVM.
ZERO: A new UAL Authenticator was created for the Native chain wrapping Metakkep service.
In both cases, the login process will take much longer the first time than subsequent times. This is because the account data is consulted the first time and then cached to avoid future queries (since it is data that will never change).
In the particular case of Telos Zero, we also have the creation of the account that is done only once, the first time the user authenticates.
Test Scenarios:
Telos EVM
If you refresh the page (press F5) you should be auto-logged as expected.
Telos Zero
If you refresh the page (press F5) you should be auto-logged as expected.