Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the home page broken style #704

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 30, 2023

Fixes #703

Description

This PR fixes the home page style that is currently displaying incorrectly.

Test scenarios

  • got to this link
    • the page should look good and not show the scrollbar (see images)

image
image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Nov 30, 2023 that may be closed by this pull request
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit dbe7220
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/65689362a3243a00074ff99e
😎 Deploy Preview https://deploy-preview-704--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit dbe7220
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/656893627964900008384eb9
😎 Deploy Preview https://deploy-preview-704--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Nov 30, 2023
@donnyquixotic donnyquixotic merged commit b6312c5 into develop Dec 2, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 703-the-home-page-needs-styling-adjustments branch December 2, 2023 00:34
@donnyquixotic donnyquixotic mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The home page needs styling adjustments.
2 participants