Make testnet faucet page more efficient by adding input validation #259 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: testnet faucet for evm only
✅ Deploy Preview for telos-app-native-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for telos-app-native-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
There are 2 supported public key formats, might be good to accept either one? Note here: https://explorer.telos.net/account/jessetest123?tab=keys You can click the key icon to toggle between the two formats (EOS vs PUB_K1 prefixed) |
|
I have added support for both public key format please check |
|
Looks good to me! |
|
Could you do review again? |
donnyquixotic
previously approved these changes
Feb 23, 2024
donnyquixotic
approved these changes
Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make testnet faucet page more efficient by adding input validation #259
Description
I have disabled the button until valid input is given and included a computed property isCreateAccountButtonDisabled that checks for valid input conditions. If any of the input fields are empty or if the Telos owner key doesn't match the specified pattern, the button will remain disabled. This helps ensure that the button is only enabled when valid input is provided, addressing the issue
Test scenarios
The test scenarios included verifying the button's disabled state under different conditions. Initially, the button remained enabled despite invalid or empty input. After the code changes, the button correctly disables when any input field is blank or when invalid input is provided for the Telos owner key and active key. The validation ensures that the "Create testnet account" button is only clickable when valid input is provided.
Checklist:
Screenshot