Add links to votable arbitrator election ballot(s) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for telos-app-native-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
donnyquixotic
approved these changes
Oct 16, 2023
| @@ -29,10 +29,18 @@ | |||
| <q-td key="ballot_name" class="ballot_name"> | |||
| <div class="info"> | |||
| <div class="ballot-name"> | |||
| <a v-if="props.row.ballot_name" :href="`/trails/ballot/${props.row.ballot_name}`"> | |||
| {{ | |||
| props.row.ballot_name || | |||
There was a problem hiding this comment.
Suggested change
| props.row.ballot_name || | |
| props.row.ballot_name |
a tag is only displayed if props.row.ballot_name exists so no need for condition
| @@ -29,10 +29,18 @@ | |||
| <q-td key="ballot_name" class="ballot_name"> | |||
| <div class="info"> | |||
| <div class="ballot-name"> | |||
| <a v-if="props.row.ballot_name" :href="`/trails/ballot/${props.row.ballot_name}`"> | |||
| {{ | |||
| props.row.ballot_name || | |||
| `${props.row.election_id}` | |||
There was a problem hiding this comment.
Suggested change
| `${props.row.election_id}` |
see previous suggestion, will never reach condition
| </a> | ||
| <span v-else> | ||
| {{ | ||
| props.row.ballot_name || |
There was a problem hiding this comment.
Suggested change
| props.row.ballot_name || |
unnec condition, will display link if exists
Merged
|
Closing because arbitration is being put on hold for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
Description
Simply added a clickable link to
/trails/ballot/{ballot_name}Test scenarios
Connected to testnet where there are elections and made sure the links worked
Checklist: