Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Resolve menu in sidebar on mobile (mainnet) #309

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

kylanhurt
Copy link
Contributor

Fixes #291

Description

Sidebar menu conditionally displays Resolve sub-menu based on NETWORK variable being set to testnet, which is why it does not display on mainnet.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Re-insert ResolveMenuItem for sidebar
@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for telos-app-native-mainnet ready!

Name Link
🔨 Latest commit 2223776
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-mainnet/deploys/64f3d9149083c50008029b20
😎 Deploy Preview https://deploy-preview-309--telos-app-native-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for telos-app-native-testnet ready!

Name Link
🔨 Latest commit 2223776
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-testnet/deploys/64f3d914137680000826a02e
😎 Deploy Preview https://deploy-preview-309--telos-app-native-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

donnyquixotic
donnyquixotic previously approved these changes Oct 16, 2023
@donnyquixotic donnyquixotic changed the base branch from master to develop October 16, 2023 19:29
@donnyquixotic donnyquixotic dismissed their stale review October 16, 2023 19:29

The base branch was changed.

@donnyquixotic donnyquixotic merged commit b963dd5 into telosnetwork:develop Oct 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve not showing on mobile navigation
2 participants