Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): allow base input box-shadow customization #5261

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

epetrow
Copy link
Contributor

@epetrow epetrow commented Dec 6, 2024

closes: 5247

@epetrow epetrow requested a review from a team as a code owner December 6, 2024 11:27
@epetrow epetrow self-assigned this Dec 6, 2024
@epetrow epetrow added Bug Something isn't working C:Input labels Dec 6, 2024
@epetrow epetrow added this to the 2025 Q1 (Feb) milestone Dec 6, 2024
@TeyaVes TeyaVes self-requested a review December 6, 2024 15:18
Copy link
Contributor

@TeyaVes TeyaVes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , I am just wondering whether we need to add a declaration and variable in the Fluent theme as well.

@TeyaVes TeyaVes requested a review from a team December 6, 2024 15:21
@TeyaVes TeyaVes requested a review from a team December 6, 2024 15:21
@inikolova inikolova self-requested a review December 6, 2024 15:29
@epetrow
Copy link
Contributor Author

epetrow commented Dec 6, 2024

LGTM , I am just wondering whether we need to add a declaration and variable in the Fluent theme as well.

I don't think we have the same concept when it comes to shadows in our Fluent inputs, but I might be mistaken.

@epetrow epetrow merged commit 3eb5d9b into develop Dec 10, 2024
27 checks passed
@epetrow epetrow deleted the fix-base-input-shadow branch December 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working C:Input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$kendo-input-shadow variable is unused
3 participants