-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NX for task management #5050
base: develop
Are you sure you want to change the base?
Conversation
6c86839
to
de03290
Compare
"lint:scripts": "eslint \"**/*.{js,jsx,ts,tsx,mjs}\"", | ||
"lint:styles": "stylelint \"**/*.scss\"", | ||
"lint:staged": "lint-staged --verbose", | ||
"build": "nx run @progress/kendo-themes-html:build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can define short package names by adding a project.json
to the respective package folder, e.g.:
packages/html/package.json
{
"name": "html",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "packages/html/src",
"projectType": "library",
"tags": []
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The npm run docs
script fails. (env: Windows)
Edited: This was sass related issue, disregard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The create-screenshots
script does not appear to work in this branch, and develop
(env: Windows)
I tested the other scrips and everything looks good, the caching for compiling sass works properly. Here are some metrics I gathered through this process (env: Windows)
|
closes: https://github.com/telerik/kendo-themes-private/issues/209