Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Java Spring with Kendo Angular app #4420

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Conversation

yanmariomenev
Copy link
Contributor

No description provided.

@yanmariomenev yanmariomenev requested a review from mbechev October 2, 2024 08:56
@yanmariomenev yanmariomenev self-assigned this Oct 2, 2024
@yanmariomenev yanmariomenev requested a review from a team as a code owner October 2, 2024 08:56
Copy link
Contributor

@mbechev mbechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. The steps were clear without any additional complexity.
Run the app on the first try.
🚀 🎊

I am adding some minor suggestions mainly to the readme.md file.

image

Comment on lines 7 to 13
1. Clone this repository by running the following command:

```bash
git clone https://github.com/telerik/kendo-angular/.git
git clone https://github.com/telerik/kendo-angular/
```

1. Make sure to have the [.NET Core 8 SDK](https://dotnet.microsoft.com/download) installed on your machine, along with [Angular CLI 18.0.6](https://v17.angular.io/guide/setup-local#install-the-angular-cli).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the file name intentionally with lowercase letters (readme.md)? In most repos the file is README.md.
Also valid for the file for the java integration.

Comment on lines +5 to +7
## Development server

Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The application will automatically reload if you change any of the source files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need npm install command to be mentioned as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main README instructions are enough and the generated one by Angular can stay without changes.


Follow these steps to set up and run the project locally:

### 1. Install Required Tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better named Prerequisites and without the number at the front.

Comment on lines 7 to 9
## Getting Started

Follow these steps to set up and run the project locally:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unnecessary. We can remove it and make the below heading from H3 to H2 (prerequisites, clone the repo, etc.)

Ensure you have the following tools installed on your machine:

- **Angular CLI (18.0.0 or later)**: A command-line interface for Angular. [Download Angular CLI](https://angular.io/cli).
- **Java Development Kit (JDK 23)**: Essential for running Java applications. [Download JDK](https://www.oracle.com/java/technologies/downloads/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue which one should be installed:
image

Pointing the user to the exact product that needs to be installed might feel better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a note, but generally ARM chips are M1 > series and x64 are Intel based Macs.

@@ -0,0 +1,93 @@
# Kendo UI for Angular Grid and Upload Component with Java Spring Boot: A Sample Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about shortening the title a bit to Kendo UI for Angular with Java Spring Boot Integration?

in the description, we can add details about the Grid and Upload.

- **Java Development Kit (JDK 23)**: Essential for running Java applications. [Download JDK](https://www.oracle.com/java/technologies/downloads/).
- **Apache Maven**: A build automation tool for Java projects. Install using [Homebrew](https://brew.sh/) on macOS, or [download manually](https://maven.apache.org/install.html).

### 2. Clone the Repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cloning of the repo could be moved to prerequisites.

git clone https://github.com/telerik/kendo-angular/
```

### 3. Set Up the Java Spring Boot Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add a H2 Setup and Run the Java Spring Boot App with a numeric list inside, listing all related information:

  1. navigate
  2. run the app
  3. the app is hosted on localhost


### 4. Set Up the Angular Project

- **Navigate to the Frontend Directory**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add a H2 Setup and Run the Angular App with a numeric list

  1. navigate .. cd ...
  2. install project dep..
  3. run the app
  4. navigate to localhost...

Comment on lines 67 to 85
## Functionality

The application demonstrates the following features:

- **Grid Component**:
- Displays a list of products.
- Supports client-side sorting, filtering, grouping, and paging using the [process helper](https://www.telerik.com/kendo-angular-ui/components/data-query/bulk-operations).
- Performs Create, Read, Update, and Delete (CRUD) operations on the server.

- **Upload Component**:
- Allows users to upload files to the server.

## Project Structure

The project consists of two main parts:

- **Frontend**: Contains the Angular application, located in the `frontend` directory.
- **Backend**: Contains the Java Spring Boot application, located in the `backend` directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good to start the document with it.
Links to the components' overview could also be beneficial.

@yanmariomenev yanmariomenev requested a review from mbechev October 4, 2024 05:35
@yanmariomenev yanmariomenev merged commit adb8b61 into master Oct 4, 2024
3 checks passed
@yanmariomenev yanmariomenev deleted the add-new-java-angular-app branch October 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants