Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v2.20.2 #3707

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Release/v2.20.2 #3707

merged 4 commits into from
Oct 21, 2024

Conversation

thallgren
Copy link
Member

Closes #3706

A traffic-manager that was installed with the Helm value
`agentInjector.enabled=false` crashed when a client used the commands
`telepresence version` or `telepresence status`. Those commands would
call a method on the traffic-manager that panicked if no traffic-agent
was present. This method will now instead return the standard
`Unavailable` error code, which is expected by the caller.

Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Oct 12, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Oct 12, 2024
@thallgren thallgren changed the base branch from release/v2.20.1 to release/v2.20 October 12, 2024 12:44
Signed-off-by: Thomas Hallgren <[email protected]>
@thallgren thallgren merged commit cfc29f2 into release/v2.20 Oct 21, 2024
8 checks passed
@thallgren thallgren deleted the release/v2.20.2 branch October 21, 2024 04:02
@thallgren thallgren restored the release/v2.20.2 branch October 21, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"panic: no ImageRetriever has been configured error" from traffic-manager
1 participant