-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear up some naming confusion around namespaceID, clusterID, and ID. #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallgren
force-pushed
the
thallgren/cli-in-docker
branch
from
January 30, 2024 06:06
6981018
to
9d89f0d
Compare
thallgren
force-pushed
the
thallgren/cluster-config
branch
2 times, most recently
from
January 30, 2024 08:09
77d37d1
to
6261e30
Compare
thallgren
force-pushed
the
thallgren/cli-in-docker
branch
from
January 30, 2024 09:12
9d89f0d
to
6c30cb3
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jan 30, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jan 30, 2024
thallgren
force-pushed
the
thallgren/cli-in-docker
branch
from
January 30, 2024 09:51
6c30cb3
to
87de23c
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jan 30, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jan 30, 2024
thallgren
force-pushed
the
thallgren/cluster-config
branch
from
January 30, 2024 09:58
6261e30
to
60054ae
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jan 30, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jan 30, 2024
thallgren
force-pushed
the
thallgren/cli-in-docker
branch
from
January 30, 2024 17:33
87de23c
to
5f57ee0
Compare
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
The command is needed to retain backward compatibility. This reverts commit 951d95a. Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/cluster-config
branch
from
January 30, 2024 17:35
60054ae
to
e8ada30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also restore the
telepresence current-cluster-id
command (for backward compatibility).