Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parent node to be of type fragment for slots #914

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

JayaKrishnaNamburu
Copy link
Member

This PR, helps in converting the parentNode to of type Fragment when the prop is of type element. We do this only if the prop's defaultValue element is of type fragment. This is to make sure, we are not converting the element type for named-slot. We do have a prop of type element which we are using for named-slot.
Here is a reference
https://github.com/teleporthq/teleport-code-generators/blob/development/examples/uidl-samples/project.json#L6726

If we don't follow the convention, we will be changing the structure of the layout. So, when you want this behaviour to kick-in. Always pass the root node of defaultValue of the prop to start with fragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant