Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert pruner keep and keep-since simultaneous support #1446

Merged

Conversation

jkandasa
Copy link
Member

Changes

tkn cli supports both "keep" and "keep-since", even though there is an issue with the logic
when we supply both "keep" and "keep-since", the outcome always equivalent to "keep", "keep-since" ignored
hence we strict with a single flag support until the issue is fixed in tkn cli
cli issue: tektoncd/cli#1990

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 13, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2023
@jkandasa
Copy link
Member Author

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 86.5% 84.6% -1.9

@vdemeester
Copy link
Member

/approve
/lgtn

@vdemeester
Copy link
Member

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2023
@tekton-robot tekton-robot merged commit 1d0fb8d into tektoncd:release-v0.65.x Apr 13, 2023
@jkandasa jkandasa deleted the fix_pruner_keep_and_keep_since branch April 13, 2023 14:17
@jkandasa
Copy link
Member Author

/cherry-pick main

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #1505

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkandasa
Copy link
Member Author

/cherry-pick release-v0.66.x

@jkandasa
Copy link
Member Author

/cherry-pick release-v0.67.x

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #1506

In response to this:

/cherry-pick release-v0.66.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #1507

In response to this:

/cherry-pick release-v0.67.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants