-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert pruner keep and keep-since simultaneous support #1446
revert pruner keep and keep-since simultaneous support #1446
Conversation
Signed-off-by: Jeeva Kandasamy <[email protected]>
The following is the coverage report on the affected files.
|
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick main |
@jkandasa: new pull request created: #1505 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v0.66.x |
/cherry-pick release-v0.67.x |
@jkandasa: new pull request created: #1506 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jkandasa: new pull request created: #1507 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
tkn cli supports both "keep" and "keep-since", even though there is an issue with the logic
when we supply both "keep" and "keep-since", the outcome always equivalent to "keep", "keep-since" ignored
hence we strict with a single flag support until the issue is fixed in tkn cli
cli issue: tektoncd/cli#1990
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes