Move pr desc to v1 CRDs

This will move pr desc to v1 CRD and remove
resources and timeouts field

Also move serviceaccountname and pipelineresults to
respective new fields

use childreferences for taskrun status and
expand params for object type too

Part of #1804

pkg/cmd/pipelinerun/cancel.go

@@ -19,10 +19,11 @@ import (
 	"strings"
 
 	"github.com/spf13/cobra"
+	"github.com/tektoncd/cli/pkg/actions"
 	"github.com/tektoncd/cli/pkg/cli"
 	"github.com/tektoncd/cli/pkg/formatted"
-	"github.com/tektoncd/cli/pkg/pipelinerun"
-	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
+	pipelinerunpkg "github.com/tektoncd/cli/pkg/pipelinerun"
+	v1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -39,7 +40,7 @@ Set to 'CancelledRunFinally' if you want to cancel the current running task and
 Set to 'StoppedRunFinally' if you want to cancel the remaining non-final task and directly run the finally tasks.
 `
 
-	cancelStatus := ""
+	graceCancelStatus := ""
 
 	c := &cobra.Command{
 		Use:     "cancel",
@@ -60,11 +61,11 @@ Set to 'StoppedRunFinally' if you want to cancel the remaining non-final task an
 				Err: cmd.OutOrStderr(),
 			}
 
-			return cancelPipelineRun(p, s, pr, cancelStatus)
+			return cancelPipelineRun(p, s, pr, graceCancelStatus)
 		},
 	}
 
-	c.Flags().StringVarP(&cancelStatus, "grace", "", "", graceCancelDescription)
+	c.Flags().StringVarP(&graceCancelStatus, "grace", "", "", graceCancelDescription)
 	return c
 }
 
@@ -74,7 +75,8 @@ func cancelPipelineRun(p cli.Params, s *cli.Stream, prName string, graceCancelSt
 		return fmt.Errorf("failed to create tekton client")
 	}
 
-	pr, err := pipelinerun.Get(cs, prName, metav1.GetOptions{}, p.Namespace())
+	var pr *v1.PipelineRun
+	err = actions.GetV1(pipelineRunGroupResource, cs, prName, p.Namespace(), metav1.GetOptions{}, &pr)
 	if err != nil {
 		return fmt.Errorf("failed to find PipelineRun: %s", prName)
 	}
@@ -85,17 +87,15 @@ func cancelPipelineRun(p cli.Params, s *cli.Stream, prName string, graceCancelSt
 		}
 	}
 
-	// nolint: staticcheck
-	cancelStatus := v1beta1.PipelineRunSpecStatusCancelled
-
+	cancelStatus := v1.PipelineRunSpecStatusCancelled
 	switch strings.ToLower(graceCancelStatus) {
-	case strings.ToLower(v1beta1.PipelineRunSpecStatusCancelledRunFinally):
-		cancelStatus = v1beta1.PipelineRunSpecStatusCancelledRunFinally
-	case strings.ToLower(v1beta1.PipelineRunSpecStatusStoppedRunFinally):
-		cancelStatus = v1beta1.PipelineRunSpecStatusStoppedRunFinally
+	case strings.ToLower(v1.PipelineRunSpecStatusCancelledRunFinally):
+		cancelStatus = v1.PipelineRunSpecStatusCancelledRunFinally
+	case strings.ToLower(v1.PipelineRunSpecStatusStoppedRunFinally):
+		cancelStatus = v1.PipelineRunSpecStatusStoppedRunFinally
 	}
 
-	if _, err = pipelinerun.Cancel(cs, prName, metav1.PatchOptions{}, cancelStatus, p.Namespace()); err != nil {
+	if _, err = pipelinerunpkg.Cancel(cs, prName, metav1.PatchOptions{}, cancelStatus, p.Namespace()); err != nil {
 		return fmt.Errorf("failed to cancel PipelineRun: %s: %v", prName, err)
 	}
 

pkg/cmd/pipelinerun/delete.go

@@ -26,7 +26,6 @@ import (
 	"github.com/tektoncd/cli/pkg/deleter"
 	"github.com/tektoncd/cli/pkg/formatted"
 	"github.com/tektoncd/cli/pkg/options"
-	pr "github.com/tektoncd/cli/pkg/pipelinerun"
 	prsort "github.com/tektoncd/cli/pkg/pipelinerun/sort"
 	v1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
 	"go.uber.org/multierr"
@@ -46,7 +45,8 @@ func prExists(args []string, p cli.Params) ([]string, error) {
 	var errorList error
 	ns := p.Namespace()
 	for _, name := range args {
-		_, err := pr.Get(c, name, metav1.GetOptions{}, ns)
+		var pr *v1.PipelineRun
+		err := actions.GetV1(pipelineRunGroupResource, c, name, ns, metav1.GetOptions{}, &pr)
 		if err != nil {
 			errorList = multierr.Append(errorList, err)
 			continue

pkg/cmd/pipelinerun/describe.go

@@ -25,9 +25,7 @@ import (
 	"github.com/tektoncd/cli/pkg/formatted"
 	"github.com/tektoncd/cli/pkg/options"
 	pipelinerunpkg "github.com/tektoncd/cli/pkg/pipelinerun"
-	prdesc "github.com/tektoncd/cli/pkg/pipelinerun/description"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime/schema"
 	cliopts "k8s.io/cli-runtime/pkg/genericclioptions"
 )
 
@@ -110,11 +108,10 @@ or
 			}
 
 			if output != "" {
-				pipelineRunGroupResource := schema.GroupVersionResource{Group: "tekton.dev", Resource: "pipelineruns"}
-				return actions.PrintObject(pipelineRunGroupResource, opts.PipelineRunName, cmd.OutOrStdout(), cs.Dynamic, cs.Tekton.Discovery(), f, p.Namespace())
+				return actions.PrintObjectV1(pipelineRunGroupResource, opts.PipelineRunName, cmd.OutOrStdout(), cs, f, p.Namespace())
 			}
 
-			return prdesc.PrintPipelineRunDescription(s, opts.PipelineRunName, p)
+			return pipelinerunpkg.PrintPipelineRunDescription(s.Out, cs, opts.Params.Namespace(), opts.PipelineRunName, opts.Params.Time())
 		},
 	}