Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): build-capable #38

Merged
merged 4 commits into from
May 26, 2024
Merged

fix(frontend): build-capable #38

merged 4 commits into from
May 26, 2024

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented May 26, 2024

No description provided.

@aldy505 aldy505 marked this pull request as ready for review May 26, 2024 08:21
@aldy505 aldy505 requested review from a team as code owners May 26, 2024 08:21
@@ -27,16 +27,11 @@ jobs:
run: pnpm install

- name: Lint
run: npx eslint --ignore-path .gitignore .
run: pnpm exec eslint --ignore-path .gitignore .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, why not use pnpm run lint here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@aldy505 aldy505 merged commit c1716d3 into master May 26, 2024
3 checks passed
@aldy505 aldy505 deleted the fix/frontend/build-things branch May 26, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants