Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove memory_limit for tengo #163

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: remove memory_limit for tengo #163

merged 2 commits into from
Feb 7, 2024

Conversation

ii64
Copy link
Contributor

@ii64 ii64 commented Feb 5, 2024

No description provided.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd35aa0) 81.17% compared to head (54b2a88) 81.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files          34       34           
  Lines        1535     1535           
  Branches      140      140           
=======================================
  Hits         1246     1246           
  Misses        223      223           
  Partials       66       66           
Flag Coverage Δ
auth 41.31% <ø> (ø)
rce 90.45% <ø> (ø)
sdk-dotnet 87.74% <ø> (ø)
sdk-go 66.48% <ø> (ø)
sdk-javascript 88.69% <ø> (ø)
sdk-python 99.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh btw this causes an error on CI. See

file:///app/dist/index.js:17861
         throw new TypeError("Invalid runtime parameters: memoryLimit is 0 or less");
               ^
   
   TypeError: Invalid runtime parameters: memoryLimit is 0 or less
       at new Runtime (file:///app/dist/index.js:17861:13)
       at acquireRuntime (file:///app/dist/index.js:17[93](https://github.com/teknologi-umum/pesto/actions/runs/7781391843/job/21219273603?pr=163#step:2:98)7:23)
       at async file:///app/dist/index.js:18002:30

You should set should_limit_memory to false and put some value on the memory_limit

@ii64
Copy link
Contributor Author

ii64 commented Feb 6, 2024

Noted that

@ii64 ii64 requested a review from aldy505 February 6, 2024 19:13
@aldy505 aldy505 merged commit 90a36ef into master Feb 7, 2024
28 checks passed
@aldy505 aldy505 deleted the feature/support-tengo branch February 7, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants