Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-sdk): bump dependencies #121

Merged
merged 4 commits into from
Jul 6, 2023
Merged

chore(js-sdk): bump dependencies #121

merged 4 commits into from
Jul 6, 2023

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Jun 18, 2023

@aldy505 aldy505 added module: sdk dependencies Pull requests that update a dependency file labels Jun 18, 2023
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.20 ⚠️

Comparison is base (27e38e8) 80.51% compared to head (5600bf2) 79.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   80.51%   79.32%   -1.20%     
==========================================
  Files          34       31       -3     
  Lines        1463     1127     -336     
  Branches       85       61      -24     
==========================================
- Hits         1178      894     -284     
+ Misses        253      202      -51     
+ Partials       32       31       -1     
Flag Coverage Δ
auth 29.59% <ø> (-4.09%) ⬇️
rce 92.58% <ø> (ø)
sdk-dotnet 96.56% <ø> (ø)
sdk-go 66.48% <ø> (ø)
sdk-javascript ?
sdk-python 99.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldy505
Copy link
Member Author

aldy505 commented Jun 19, 2023

Blocked by teknologi umum's eslint config release. Ping @elianiva

@aldy505
Copy link
Member Author

aldy505 commented Jul 2, 2023

Ping @elianiva, please review, thx

Copy link
Contributor

@RayWP RayWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldy505 aldy505 merged commit 6163631 into master Jul 6, 2023
24 of 26 checks passed
@aldy505 aldy505 deleted the chore/sdk-js/bump-deps branch July 6, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file module: sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants