feat: analytic #95
Merged
feat: analytic #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WahidinAji
approved these changes
May 21, 2024
aldy505
reviewed
May 22, 2024
frontend/nuxt.config.ts
Outdated
Comment on lines
3
to
10
| extends: ['nuxt-umami'], | ||
| appConfig: { | ||
| umami: { | ||
| id: process.env.UMAMI_ID, | ||
| host: process.env.UMAMI_HOST, | ||
| useDirective: true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Please use Nuxt's useHead instead of depending on this module. It's just a one line of <script> tag anyway
frontend/pages/2023.vue
Outdated
| @@ -61,7 +61,7 @@ const showVideo = ref(false) | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 24 24"><path fill="currentColor" d="M12 6.5A2.5 2.5 0 0 1 14.5 9a2.5 2.5 0 0 1-2.5 2.5A2.5 2.5 0 0 1 9.5 9A2.5 2.5 0 0 1 12 6.5M12 2a7 7 0 0 1 7 7c0 5.25-7 13-7 13S5 14.25 5 9a7 7 0 0 1 7-7m0 2a5 5 0 0 0-5 5c0 1 0 3 5 9.71C17 12 17 10 17 9a5 5 0 0 0-5-5Z"/></svg> | |||
| <span>Kode Creative Hub, Depok Town Square<br/>Depok, Indonesia</span> | |||
| </h3> | |||
| <Btn :is-link="true" to="/" class="mt-5 lg:mt-15 text-center btn-save-my-spot" size="xl">Back to Current Event</Btn> | |||
| <Btn v-umami="{name: 'go-to-2024-page-btn'}" :is-link="true" to="/" class="mt-5 lg:mt-15 text-center btn-save-my-spot" size="xl">Back to Current Event</Btn> | |||
There was a problem hiding this comment.
If we're moving to Nuxt's useHead composable, we should be using the custom umami directive. That should be easy enough.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
WahidinAji
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to set ENV: