SearchType.Accordion UX improvement (backstage#26935)

* Update default SearchType.Accordion behavior to NOT close accordion after selection.

Signed-off-by: Sydney Achinger <[email protected]>

.changeset/shy-plants-retire.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-search': patch
+---
+
+Updated the default SearchType.Accordion behavior to remain open after result type selection. This is a UX improvement to reduce the number of clicks needed when toggling result type filters.

plugins/search/src/components/SearchType/SearchType.Accordion.test.tsx

@@ -140,18 +140,6 @@ describe('SearchType.Accordion', () => {
     expect(setPageCursorMock).toHaveBeenCalledWith(undefined);
   });
 
-  it('should collapse when a new type is selected', async () => {
-    const { getByText, queryByText } = render(
-      <Wrapper>
-        <SearchType.Accordion name={expectedLabel} types={[expectedType]} />
-      </Wrapper>,
-    );
-
-    await user.click(getByText(expectedType.name));
-
-    expect(queryByText('Collapse')).not.toBeInTheDocument();
-  });
-
   it('should show result counts if enabled', async () => {
     const { getAllByText } = render(
       <Wrapper>

plugins/search/src/components/SearchType/SearchType.Accordion.tsx

@@ -96,7 +96,6 @@ export const SearchTypeAccordion = (props: SearchTypeAccordionProps) => {
     return () => {
       setTypes(type !== '' ? [type] : []);
       setPageCursor(undefined);
-      setExpanded(false);
     };
   };