Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export PATH with TMT_SCRIPTS_DIR if needed #3368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Export PATH with TMT_SCRIPTS_DIR if needed #3368

wants to merge 1 commit into from
+13 −3

Conversation

thrix
Copy link
Collaborator

@thrix thrix commented Nov 19, 2024 •
edited
Loading

Make sure we export the PATH with TMT_SCRIPTS_DIR in case it is needed. This is needed if tests scripts call distributed tmt scripts.

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@thrix thrix added this to the 1.39 milestone Nov 19, 2024
@happz happz added the step | execute Stuff related to the execute step label Nov 19, 2024
@martinhoyer martinhoyer self-requested a review November 19, 2024 10:27
@seberm seberm self-requested a review November 19, 2024 11:51
@thrix thrix requested a review from happz November 19, 2024 12:59
@thrix thrix added the priority | must high priority, must be included in the next release label Nov 19, 2024
@psss psss added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. ci | full test Pull request is ready for the full test execution labels Nov 19, 2024
@thrix @psss
Export PATH with TMT_SCRIPTS_DIR if needed
0ac37e7 
Make sure we export the `PATH` with `TMT_SCRIPTS_DIR` in case
it is needed. This is needed if tests scripts call distributed
tmt scripts.

Signed-off-by: Miroslav Vadkerti <[email protected]>
@psss psss changed the title Export PATH with TMT_SCRIPTS_DIR if needed Export PATH with TMT_SCRIPTS_DIR if needed Nov 19, 2024
@psss
Copy link
Collaborator

psss commented Nov 19, 2024

Seems the updated test is failing:

:: [ 14:41:27 ] :: [   FAIL   ] :: File '/var/tmp/rlRun_LOG.mDV3wYfz' should contain 'PATH=.*/var/lib/tmt/scripts.*'

@thrix, can you have a look?

@psss psss removed the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@seberm seberm seberm approved these changes

@happz happz happz approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release step | execute Stuff related to the execute step
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.
5 participants
@thrix @psss @happz @seberm @therazix