Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the pidfile accessible by everyone #3252

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Make the pidfile accessible by everyone #3252

wants to merge 7 commits into from
+34 −6

Commits on Nov 19, 2024

  1. Makes the pidfile accessible by everyone 

    Creates the pidfile at an accessible location
for every user, this way the manage pidfile
warning is avoided.

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    49ff170 View commit details
    Browse the repository at this point in the history

  2. Adds a check to only create the pid directory 

    when it doesn't exist.

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    031f275 View commit details
    Browse the repository at this point in the history

  3. Fixes the tmt reboot test, updating the pidfile location in the scripts. 

    Also formats the pid directory creation command.

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fdce4c0 View commit details
    Browse the repository at this point in the history

  4. Updates the environment variables in out-of-session test. 

    This way we avoid TestingFarm to set the old values.

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    51214db View commit details
    Browse the repository at this point in the history

  5. Removes the sudo(s) from tmt commands and instead apply it directly 

    in the pidfile creation. Also includes the super().setup() call to
the setup GuestSsh function.

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0fe0ef7 View commit details
    Browse the repository at this point in the history

  6. Removes the self.become this way the condition is applied 

    every time the user has no privileges

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1907d53 View commit details
    Browse the repository at this point in the history

  7. Changes bfu_* options to use unprivileged Fedora container image 

    and fedora user

Signed-off-by: mcasquer <[email protected]>
    @mcasquer
    mcasquer committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ea92b5a View commit details
    Browse the repository at this point in the history