Support Fedora Image Mode #3229
Open
+116
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrix
added a commit
to testing-farm/gluetool-modules
that referenced
this pull request
Sep 20, 2024
With tmt from this MR: teemtee/tmt#3229 Signed-off-by: Miroslav Vadkerti <[email protected]>
thrix
force-pushed
the
image-mode-fedora
branch
from
8c1c5db
to
b447a6a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
happz
reviewed
Sep 30, 2024
happz
reviewed
Sep 30, 2024
happz
reviewed
Sep 30, 2024
happz
reviewed
Sep 30, 2024
thrix
force-pushed
the
image-mode-fedora
branch
4 times, most recently
from
5617f1e
to
71c72d1
Compare
To support Fedora Image mode the following changes were required: * Fix `rsync` installation. The tool is not included in the distribution and the installation method was completely broken, i.e. `rpm-ostree` has no `--install-root` option. We did not hit it as there is no good testing environment available that would cover this. * Introduce `TMT_SCRIPTS_DEST_DIR` environment variable set by default to `/var/tmp/tmt/bin` which hosts the `tmt` scripts. The original path is not writable on these systems. The `PATH` is set system wide via a new `/etc/profile.d/tmt.sh` script. Signed-off-by: Miroslav Vadkerti <[email protected]>
thrix
force-pushed
the
image-mode-fedora
branch
from
71c72d1
to
4d0abe1
Compare
happz
reviewed
Oct 1, 2024
happz
reviewed
Oct 1, 2024
martinhoyer
reviewed
Oct 1, 2024
thrix
added
the
priority | must
thrix
force-pushed
the
image-mode-fedora
branch
from
517fb79
to
0b923ee
Compare
To support Fedora Image mode the following changes were required: * Fix `rsync` installation. The tool is not included in the distribution and the installation method was completely broken, i.e. `rpm-ostree` has no `--install-root` option. We did not hit it as there is no good testing environment available that would cover this. * Introduce `TMT_SCRIPTS_DEST_DIR` environment variable set by default to `/var/tmp/tmt/bin` which hosts the `tmt` scripts. The original path is not writable on these systems. The `PATH` is set system wide via a new `/etc/profile.d/tmt.sh` script. Signed-off-by: Miroslav Vadkerti <[email protected]>
thrix
force-pushed
the
image-mode-fedora
branch
from
0b923ee
to
97d2b90
Compare
thrix
commented
Oct 1, 2024
thrix
commented
Oct 1, 2024
thrix
commented
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Fedora Image mode the following changes were required:
Fix
rsyncinstallation. The tool is not included in the distribution andthe installation method was completely broken, i.e.
rpm-ostreehasno
--install-rootoption. We did not hit it as there is no goodtesting environment available that would cover this.
Introduce
TMT_SCRIPTS_DEST_DIRenvironment variable set by defaultto
/var/tmp/tmt/binwhich hosts thetmtscripts. The original pathis not writable on these systems. The
PATHis set system wide via anew
/etc/profile.d/tmt.shscript.Signed-off-by: Miroslav Vadkerti [email protected]
Pull Request Checklist