Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tcpdf.php for #681 #682

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

nshiddqui
Copy link

remicollet and others added 23 commits September 6, 2023 08:51
…#620)

Tested and confirmed working in PHP 7.4 and PHP 8.2
* README: tone down the warning about tc-lib-pdf

Signed-off-by: Ruben Barkow-Kuder <[email protected]>

* Update README.md

Co-authored-by: William Desportes <[email protected]>

---------

Signed-off-by: Ruben Barkow-Kuder <[email protected]>
Co-authored-by: William Desportes <[email protected]>
* Fix of Deprecation warning with php 8.1 tecnickcom#614

* Update include/barcodes/qrcode.php

Co-authored-by: William Desportes <[email protected]>

---------

Co-authored-by: Robert Johnson Nallori <[email protected]>
Co-authored-by: johnson361 <[email protected]>
Co-authored-by: William Desportes <[email protected]>
…om#633)

* Update tcpdf_fonts.php

Fixes "use of "self" in callables is deprecated" warning is arising from tcpdf_fonts.php when using PHP >= 8.2

* Update tcpdf_fonts.php for PHP 5.3-8.2 compatibility

PHP 8.2 "use of "self" in callables is deprecated" yet some ways of fixing this breaks for PHP 5.3. This approach works, tested PHP 5.3.29 - 8.2.0

* Update tcpdf_fonts.php

Spaces added back in before arguments

* Update tcpdf_fonts.php using get_called_class()

Maneuvers compatibility of callables inside array_map() between PHP 5.3 and 8.2 - tested.

---------

Co-authored-by: Nicola Asuni <[email protected]>
* Fix composite glyph output

* Pad zeros before checksum calulation

---------

Co-authored-by: Nicola Asuni <[email protected]>
* fix for tecnickcom#583

* fix fix

---------

Co-authored-by: Nicola Asuni <[email protected]>
* Fix non-numeric value warning

Fixes this warning on generating PDF:
Warning: A non-numeric value encountered in /tcpdf/tcpdf.php on line 5473

* Better fix for non-numeric value warning

Fixes this warning on generating PDF after calling `Text` with a non-numeric value for `$fstroke`:
Warning: A non-numeric value encountered in /tcpdf/tcpdf.php on line 5470

* Update tcpdf.php

Co-authored-by: William Desportes <[email protected]>

---------

Co-authored-by: William Desportes <[email protected]>
Co-authored-by: Nicola Asuni <[email protected]>
This was already fixed in tc-lib-barcode.
* Fix return type annotation

* BC with tools that do not support PHPStan annotations

Co-authored-by: William Desportes <[email protected]>

---------

Co-authored-by: William Desportes <[email protected]>
Co-authored-by: Nicola Asuni <[email protected]>
tecnickcom#598)

* Typehints for get/setHeaderMargin are inconstent

* Add typehints for header/footer margin properties

---------

Co-authored-by: Nicola Asuni <[email protected]>
* Bump actions/checkout and add PHP 8.3

* Update the composer json tests

* Remove PHP 5.3 and 5.4 from the matrix

* add permission entry

Restrict GitHub actions access

---------

Co-authored-by: Nicola Asuni <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024

CLA assistant check
All committers have signed the CLA.

tcpdf.php Show resolved Hide resolved
@nshiddqui
Copy link
Author

nshiddqui commented Jan 25, 2024

@williamdes i have added the params details over the function description. please approve it, so i can use it on my project ASAP.
Thanks

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
@nicolaasuni do we accept new parameters?

@nicolaasuni
Copy link
Member

Please try to resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.