➕ Add default values to roles

[bdsoha]

Proposed Changes

• Add default values to roles to refrain from missing values in the all.yml file.
• Allow modular use of roles when consumed as a collection.
• Add metadata to all roles with documented arguments.

Checklist

• Tested locally
• Ran site.yml playbook
• Ran reset.yml playbook
• Did not add any unnecessary changes
• Ran pre-commit install at least once before committing
• 🚀

[bdsoha]

@timothystewart6 It would be great to receive your input on whether or not such a PR is in the roadmap for this project.
If so, I will continue the work for all other roles.

[bdsoha]

@timothystewart6 Did you have a chance to look at this?

[timothystewart6]

@timothystewart6 Did you have a chance to look at this?

Hi! Yes, this sounds great as long as we don't break how it currently works. Unfortunately CI isn't working right now but I hope to have it working soon so that the tests will run!

Thanks!
Tim

[timothystewart6]

Just let me know when this is ready!

[bdsoha]

No problem, I will change the PR status from draft to ready.

[bdsoha]

@timothystewart6 Ready for review!

[timothystewart6]

@bdsoha it seems this is failing CI

see logs: https://github.com/techno-tim/k3s-ansible/actions/runs/10134226628/job/28020331172

seems like you are mixing snake_case and camelCase. I would just make them all snake_case and one small conflict after all the merges

[bdsoha]

@timothystewart6 I didn't choose the variable names, just used the existing ones (which might cause regression failures for users of the playbook).
Therefore, I added ignore statements to the relevant lines.

pre-commit is passing locally for me.

[timothystewart6]

Well they were only in a template before now they are set as defaults and used elsewhere. I think you maybe have missed some ignores. There are also conflicts too. Although it does work locally, you might be on a different version? It does need to pass CI since it's the source of truth.

[bdsoha]

@timothystewart6
You are referring to a CI run from a previous commit (before I added the ignore statements).
There is no CI run for the most recent commit which resolves the issues.

The most recent commit is "requires approval from a maintainer".

[timothystewart6]

@bdsoha sorry! Good call! There are still conflict though however

[bdsoha]

@timothystewart6 Done!

[timothystewart6]

Unfortunately it's not passing CI