Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure role label on nodes #312

Closed
wants to merge 2 commits into from
Closed

Conversation

sagiru
Copy link

@sagiru sagiru commented May 30, 2023

it is generally more pleasant to set these roles.

Proposed Changes

Ensure the node role is configured as expected instead of beeing none.

(.venv) sascha@apu:~/git/dmix/ansible-infra$ k get nodes
NAME        STATUS   ROLES                       AGE   VERSION
...
intkwkr01   Ready    worker                      19d   v1.24.12+k3s1
intkwkr02   Ready    none                     19d   v1.24.12+k3s1

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

it is generally more pleasant to set these roles.
@sagiru
Copy link
Author

sagiru commented Jun 1, 2023

sascha@apu:~/.../k3s-ansible$ ansible-lint roles/k3s/post/tasks/main.yml 
WARNING: PATH altered to expand ~ in it. Read https://stackoverflow.com/a/44704799/99834 and correct your system configuration.

Passed with production profile: 0 failure(s), 0 warning(s) on 2 files.

To use label base node selectors for pods it could be useful to label
the worker nodes additionally.
@timothystewart6
Copy link
Contributor

Looks like there are merge conflicts now, would love to merge this in at some point!

@timothystewart6
Copy link
Contributor

We should probably go this route instead #339 Also, closing due to conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants