Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resume.html space between interests commas #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elwais
Copy link

@elwais elwais commented Sep 3, 2024

While getting the professional portfolio set up for ICS 314, I noticed spacing issues in the "Interests" section of the "Resume" page.

By adding hyphens at the start and end of the Liquid tags and refactoring the one-liner into several lines, spacing issues were fixed while improving readability (at least in my humble opinion).

Before:
image

After:
image

These were generated from the following set of interests in bio.json:

    "interests": [
        {
            "name": "DevOps"
        },
        {
            "name": "Terminal-based workflows"
        },
        {
            "name": "Linux",
            "keywords": ["Keyword1", "Keyword2"]
        },
        {
            "name": "Digital signal processing",
        }
    ]

More information on whitespace control can be found here.


As an aside, I am not familiar with the processes/etiquette behind contributing via pull requests, and wasn't sure if there was a particular set of guidelines to contributing to Techfolios. Please let me know if I can improve anywhere in that regard.

Using hyphens at the start and end of the Liquid (templating system used by Jekyll) tags allowed for whitespace stripping, which removes the spaces before the commas and around the parentheses (in the case of multiple keywords).

See https://shopify.github.io/liquid/basics/whitespace/ for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant