Intake #14
Intake #14
Conversation
…to be different again.
There was a problem hiding this comment.
-
https://github.com/team4099/Crescendo-2024/blob/5ebeadf28a3d77a939f4a56b5ec6e9b097[…]/main/kotlin/com/team4099/robot2023/subsystems/intake/Intake.kt don't have idle subsystem states
open loop and idle in this case are functionally equivalent. reuse open loop state for idle and in superstructure just request openloop with idle roller voltage. the reason is bc if you have to make a change to the logic in one for some reason, you would also have to do make it in the other which is just unnecessary when they do the same thing. -
https://github.com/team4099/Crescendo-2024/blob/5ebeadf28a3d77a939f4a56b5ec6e9b097[…]/kotlin/com/team4099/robot2023/subsystems/intake/IntakeIONEO.kt just get rid of this
-
https://github.com/team4099/Crescendo-2024/blob/5ebeadf28a3d77a939f4a56b5ec6e9b097[…]/kotlin/com/team4099/robot2023/subsystems/intake/IntakeIONEO.kt this will break motor checker bc it requires you two have different current limits
otherwise looks really good!
There was a problem hiding this comment.
This file should not be in the repo, please to add to gitignore
No description provided.